Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on updating sandbox cluster configuration #4510

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Nov 30, 2023

Describe your changes

Adds notes on updating and reloading Flyte sandbox cluster configuration.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb marked this pull request as ready for review November 30, 2023 23:50
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 30, 2023
pingsutw
pingsutw previously approved these changes Nov 30, 2023
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 30, 2023
@jeevb jeevb enabled auto-merge (squash) November 30, 2023 23:53
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64f097f) 59.40% compared to head (934d1d0) 59.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4510   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         638      638           
  Lines       53957    53957           
=======================================
  Hits        32052    32052           
  Misses      19376    19376           
  Partials     2529     2529           
Flag Coverage Δ
unittests 59.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 1, 2023
@jeevb jeevb merged commit a8f4904 into master Dec 1, 2023
45 checks passed
@jeevb jeevb deleted the jeev/sandbox-docs branch December 1, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants