change artifacts http mappings again #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: squiishyy <joe@union.ai>
dosubot
bot
added
the
size:L
squiishyy
added a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: squiishyy <joe@union.ai>
eapolinario
added a commit
that referenced
this pull request
Dec 27, 2023
* use-personal * tidy * update port to 30004 Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artifacts bundle (#7) * Remove private repos (#4078) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * nit from monorepo merge Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artifacts bring in idl (#4204) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artifacts bring admin monorepo (#4203) Main pr to bring in the boilerplate code for artifact service into the main pr. Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Artf/triggers (#4394) This PR adds the trigger concept. Other changes: * Forgot to make the index on artifactkey unique. * Fix to create artifact, it wasn't pulling back out the artifact key. * Updated the Artifact service to handle the passing of artifacts created by the events processor to the trigger handling components. Currently, and this is potentially a design flaw, the events processor has no way of contacting the trigger component directly. Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * make trigger key index unique (#4410) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * revert data proxy changes (#4411) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * artf/ fix issue with trigger (#4412) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * sandbox lite dockerfile (#4413) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * More pgconn handling fixes (#4420) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artf/switch event (#4428) Most of the changes here are generated proto changes. Actual code changes are: IDL * Remove the supplemental fields in the CloudEventTaskExecution object and move them to CloudEventNodeExecution object. * Remove some fields that the artifact service ended up not using (parent_node_execution and scheduled_at) in the cloudevent publisher, change the code filling in of the aforementioned supplemental information to happen for node execution events instead of task execution events. * Remove the deleted fields. On the event handling side, move the logic to the handling of the node event instead of the task event. Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Artf/lints (#4429) * lint fixes * rename sandbox_utils without underscore Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * look for other places where pgconn is cast and add handling (#4430) Add additional handling of pgconn * Change datacatalog logic to use flytestdlib function instead. * Change flytestdlib constants to capitalize * Add handling of the other type to Admin code directly Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add artifacts branch to buf push (#4448) Signed-off-by: squiishyy <joe@union.ai> * add dummy comment (#4451) Signed-off-by: squiishyy <joe@union.ai> * add dummy comment again (#4453) Signed-off-by: squiishyy <joe@union.ai> * artf/updates to source (#4443) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add a feature gate (#4472) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * fix bug in execution_manager with lpExpectedInputs, remove the standalone artifact client and move into idl clientset, update local config file, remove a deprecated function (#4473) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * initial deletion of artifact code Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * running make manifests in docker/sandbox-bundled to update generated files Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * now compiles (#4481) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add a debug line Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * more debugging Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * clean up go mod and switch the order of the input extraction to check for uri first Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * change artifacts http mappings in protos Signed-off-by: squiishyy <joe@union.ai> * testing removal of go mod pin Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * update go mod some more Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * copilot go mod Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * change artifacts http mappings again (#4562) Signed-off-by: squiishyy <joe@union.ai> * panic and revert gorm log level change Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * revert local to 5 Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * make helm Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Reclaim space prior to running functional tests in single-binary Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Pin flytectl version to 0.8.0 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Pin flytectl version to 0.8.0" This reverts commit cfa4745. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use flytagent v1.10.2 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Debug single-binary Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use an infinite loop instead of watch (term env var is not set) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Get logs from single-binary pod Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Debug single-binary pod: use a different way of choosing the pod Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix flytectl version Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use port 5432 to connect to postgres Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Use port 5432 to connect to postgres" This reverts commit 8ded67b. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Fix flytectl version" This reverts commit 3968d40. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * fix database error Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * revert .github/workflows/single-binary.yml by pulling from master Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Review feedback Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: squiishyy <joe@union.ai> Co-authored-by: Joe Eschen <126913098+squiishyy@users.noreply.github.com> Co-authored-by: squiishyy <joe@union.ai> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed some in my previous PR: #4554
Ran
make generateas well