move pod start/end time to a common template vars #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pod start/end time is useful to have even with TemplateSchemeTaskExecution, to construct precise timerange in the URL. Signed-off-by: vraiyani <vraiyani@nvidia.com>
dosubot
bot
added
size:M
kumare3
approved these changes
Jan 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4676 +/- ##
==========================================
+ Coverage 58.13% 58.16% +0.02%
==========================================
Files 626 626
Lines 53782 53786 +4
==========================================
+ Hits 31266 31282 +16
+ Misses 20008 19998 -10
+ Partials 2508 2506 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Jan 8, 2024
katrogan
pushed a commit
that referenced
this pull request
Jan 12, 2024
pod start/end time is useful to have even with TemplateSchemeTaskExecution, to construct precise timerange in the URL. Signed-off-by: vraiyani <vraiyani@nvidia.com> Co-authored-by: David Espejo <82604841+davidmirror-ops@users.noreply.github.com> Co-authored-by: Kevin Su <pingsutw@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently, in the tasklog template, task pod start end/time is only supported with
TemplateSchemePodscheme. It is useful to have it forTemplateSchemeTaskExecutionscheme as well to construct URLs with correct time ranges (eg. Grafana Metrics Dashboard for multi-worker training jobs)What changes were proposed in this pull request?
Move pod start/end time temalateVars to common section.
How was this patch tested?
Unit-testes