Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(troubleshoot): Add docker error troubleshooting guide #4972

Merged

Conversation

MortalHappiness
Copy link
Contributor

Tracking issue

N/A

Why are the changes needed?

Some users like me encountered the docker error while trying to start Flyte.

Untitled

What changes were proposed in this pull request?

Add troubleshooting guide for docker error.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 28, 2024
pingsutw
pingsutw previously approved these changes Feb 29, 2024
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.10%. Comparing base (8bb5b8c) to head (02154d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4972   +/-   ##
=======================================
  Coverage   59.09%   59.10%           
=======================================
  Files         645      645           
  Lines       55540    55540           
=======================================
+ Hits        32824    32825    +1     
+ Misses      20127    20126    -1     
  Partials     2589     2589           
Flag Coverage Δ
unittests 59.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes requested, otherwise looks good. Thanks!

docs/community/troubleshoot.rst Outdated Show resolved Hide resolved
docs/community/troubleshoot.rst Outdated Show resolved Hide resolved
docs/community/troubleshoot.rst Outdated Show resolved Hide resolved
docs/community/troubleshoot.rst Outdated Show resolved Hide resolved
docs/community/troubleshoot.rst Outdated Show resolved Hide resolved
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness
Copy link
Contributor Author

@neverett Fixed. Thank you.

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pingsutw pingsutw enabled auto-merge (squash) March 29, 2024 08:56
@pingsutw pingsutw merged commit 6568582 into flyteorg:master Apr 8, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants