Feature/array node workflow parallelism #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5062 +/- ##
==========================================
+ Coverage 59.06% 59.07% +0.01%
==========================================
Files 646 646
Lines 55726 55740 +14
==========================================
+ Hits 32916 32930 +14
Misses 20214 20214
Partials 2596 2596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
dosubot
bot
added
size:M
hamersaw
reviewed
Mar 21, 2024
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
dosubot
bot
added
size:L
hamersaw
previously approved these changes
Apr 4, 2024
…elism Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
|
@hamersaw could I get another +1 on this - had to resolve a merge conflict |
hamersaw
approved these changes
Apr 4, 2024
Jeinhaus
pushed a commit
to Jeinhaus/flyte
that referenced
this pull request
Apr 8, 2024
* update arraynode proto parallelism field to varint compatible int64 Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * have array nodes utilize workflow parallelism Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * return if available parallelism is 0 Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * unit test Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
May 1, 2024
* Feature/array node workflow parallelism (#5062) * update arraynode proto parallelism field to varint compatible int64 Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * have array nodes utilize workflow parallelism Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * return if available parallelism is 0 Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * unit test Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * enable parallelism to be set to nil for array node (#5214) * enable parallelism to be set to nil for array node Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * unit test Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * added configuration for arraynode default parallelism behavior (#5268) * added configuration for arraynode default parallelism behavior Signed-off-by: Daniel Rammer <daniel@union.ai> * added unit tests and fixed linter Signed-off-by: Daniel Rammer <daniel@union.ai> * cleanup / docs Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed ytpo Signed-off-by: Daniel Rammer <daniel@union.ai> * docs update Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed unit tests Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Signed-off-by: Daniel Rammer <daniel@union.ai> Co-authored-by: Paul Dittamo <37558497+pvditt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3924
Why are the changes needed?
Add support for array nodes to utilize the workflow parallelism.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link