Update K8s plugin config docs #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2024 14:09
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
dosubot
bot
added
size:XL
davidmirror-ops
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5070 +/- ##
==========================================
+ Coverage 59.00% 59.10% +0.10%
==========================================
Files 645 645
Lines 55542 55574 +32
==========================================
+ Hits 32770 32846 +76
+ Misses 20181 20135 -46
- Partials 2591 2593 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@davidmirror-ops OK if i review this now or would you like me to wait until it's marked as ready for review and not draft? |
Signed-off-by: davidmirror-ops <david espejo@union.ai>
|
@neverett Thanks Nikki, it's still a WIP. This page has several outdated/incorrect/missing sections. Once it's ready for review you can through your magic :) |
added 18 commits
March 19, 2024 13:09
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
dosubot
bot
added
size:XXL
davidmirror-ops
changed the title
added 2 commits
March 26, 2024 07:00
Signed-off-by: davidmirror-ops <david espejo@union.ai>
Signed-off-by: davidmirror-ops <david espejo@union.ai>
|
@neverett ready for review :) |
neverett
previously approved these changes
Mar 28, 2024
| - kind: ServiceAccount | ||
| name: spark | ||
| namespace: "{{ namespace }}" | ||
| This guide help you configure the Flyte plugins that provision resources on Kubernetes. |
There was a problem hiding this comment.
Suggested change
| This guide help you configure the Flyte plugins that provision resources on Kubernetes. | |
| This guide will help you configure the Flyte plugins that provision resources on Kubernetes. |
|
|
||
| See :ref:`deployment-configuration-general` for more information about Pod templates in Flyte. | ||
| You can set the scheduler name in the Pod template passed to the ``@task`` decorator. However, to prevent the | ||
| two different schedulers from competing for resources, it is recommended to set the scheduler name in the pod template |
There was a problem hiding this comment.
Suggested change
| two different schedulers from competing for resources, it is recommended to set the scheduler name in the pod template | |
| two different schedulers from competing for resources, we recommend setting the scheduler name in the pod template |
|
|
||
| 2. (Optional) The Spark operator supports Kubernetes ResourceQuota enforcement. If you plan to use it, | ||
| set `per-Task resource requests <https://docs.flyte.org/en/latest/user_guide/productionizing/customizing_task_resources.html#customizing-task-resources>`__ that fit into the quota for each project-namespace. A Task without resource requests | ||
| or limits will be rejected by the K8s scheduler as described `in the docs <https://kubernetes.io/docs/concepts/policy/resource-quotas/>`__. |
There was a problem hiding this comment.
Suggested change
| or limits will be rejected by the K8s scheduler as described `in the docs <https://kubernetes.io/docs/concepts/policy/resource-quotas/>`__. | |
| or limits will be rejected by the K8s scheduler as described `in the Kubernetes docs <https://kubernetes.io/docs/concepts/policy/resource-quotas/>`__. |
Signed-off-by: davidmirror-ops <david espejo@union.ai>
neverett
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #5065
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link