[House keeping] remove setting max size bytes in node context

[pvditt]

Tracking issue

#4487

Why are the changes needed?

#4852 deprecated the max-output-size-bytes propeller config in favor of maxDownloadMBs storage config. This made setting MaxSizeBytes in NodeExecutionContext no longer needed as we can just read that config when reading an output file.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

#4852

Docs link

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 58.98%. Comparing base (2db8eed) to head (b31f638).
Report is 96 commits behind head on master.

Files	Patch %	Lines
...uginmachinery/ioutils/remote_file_output_reader.go	0.00%	7 Missing ⚠️
flyteplugins/go/tasks/plugins/testing/echo.go	0.00%	1 Missing ⚠️
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go	0.00%	1 Missing ⚠️
...ugins/go/tasks/plugins/webapi/databricks/plugin.go	0.00%	1 Missing ⚠️
flytepropeller/pkg/controller/controller.go	0.00%	1 Missing ⚠️
...ytepropeller/pkg/controller/nodes/array/handler.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5092      +/-   ##
==========================================
- Coverage   58.99%   58.98%   -0.02%     
==========================================
  Files         645      645              
  Lines       55648    55649       +1     
==========================================
- Hits        32831    32826       -5     
- Misses      20222    20228       +6     
  Partials     2595     2595              

Flag	Coverage Δ
unittests	58.98% <50.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hamersaw]

is there an issue with just removing the maxPayloadSize completely? IIUC there is just the two checks in this file. IMO the maxDownloadMBs applied on the data store retrieval would catch these first.

[pvditt]

I should've mentioned this in the PR - I had some concern if there were any swaps with an external datastore implementation as mentioned in this comment. This external implementation might not have checks against maxDownloadMBs as we do in stow_store.

This is probably an unfound concern and we could just mention in release notes about potential payload size issues if you're using an external storage implementation.