Remove unnecessary step and fix numbering in code examples #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
dosubot
bot
added
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5104 +/- ##
==========================================
+ Coverage 58.49% 59.00% +0.50%
==========================================
Files 627 645 +18
Lines 54155 55670 +1515
==========================================
+ Hits 31680 32850 +1170
- Misses 19942 20224 +282
- Partials 2533 2596 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Mar 26, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
https://github.com/flyteorg/flyte/pull/4509/files removed the unnecessary step, but during the monodocs work we ended up bringing that step back.
What changes were proposed in this pull request?
Remove the need to use
sedto replace the contents of the$HOMEenv var inflyte-single-binary-local.yaml.I also added a single space between the word
Stepand the number to increase readability.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link