Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-jose v3.0.0 -> v3.0.3 #5154

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

ddl-ebrown
Copy link
Contributor

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. security Issues related to Security improvements labels Mar 30, 2024
 - Resolves vulns

   GO-2023-2334
   CVE-2024-28180

Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com>
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.11%. Comparing base (f5f8230) to head (76f416a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5154      +/-   ##
==========================================
+ Coverage   59.10%   59.11%   +0.01%     
==========================================
  Files         645      645              
  Lines       55574    55574              
==========================================
+ Hits        32846    32852       +6     
+ Misses      20135    20129       -6     
  Partials     2593     2593              
Flag Coverage Δ
unittests 59.11% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 1, 2024
@eapolinario eapolinario merged commit ba86c69 into flyteorg:master Apr 1, 2024
48 checks passed
@ddl-ebrown ddl-ebrown deleted the update-go-jose branch April 1, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer security Issues related to Security improvements size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants