[House keeping] include container statuses for all container exit errors #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5161 +/- ##
==========================================
+ Coverage 59.08% 59.11% +0.02%
==========================================
Files 645 645
Lines 55574 55579 +5
==========================================
+ Hits 32838 32857 +19
+ Misses 20142 20129 -13
+ Partials 2594 2593 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
dosubot
bot
added
size:M
hamersaw
approved these changes
Apr 4, 2024
hamersaw
deleted the
housekeeping/include-container-status-in-error-message
branch
Jeinhaus
pushed a commit
to Jeinhaus/flyte
that referenced
this pull request
Apr 8, 2024
…ors (flyteorg#5161) * include container statuses for all container exit errors Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * add unit test Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link