Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to AuthMetadataService in flyte-binary chart #5185

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Apr 5, 2024

Tracking issue

Closes #5186

Why are the changes needed?

We missed a start to this path in #4946.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.08%. Comparing base (24a6e4e) to head (6247f91).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5185      +/-   ##
==========================================
+ Coverage   58.88%   59.08%   +0.20%     
==========================================
  Files         568      646      +78     
  Lines       47967    55740    +7773     
==========================================
+ Hits        28243    32935    +4692     
- Misses      17309    20209    +2900     
- Partials     2415     2596     +181     
Flag Coverage Δ
unittests 59.08% <ø> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario enabled auto-merge (squash) April 5, 2024 01:15
Copy link
Contributor

@lowc1012 lowc1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@eapolinario eapolinario merged commit 44c701e into master Apr 5, 2024
53 checks passed
@eapolinario eapolinario deleted the fix-flyte-binary-missing-start branch April 5, 2024 02:46
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 5, 2024
Jeinhaus pushed a commit to Jeinhaus/flyte that referenced this pull request Apr 8, 2024
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Auth calls not hitting the single-binary
3 participants