Change phase to WaitingForResources when quota exceeded #5195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@gmail.com>
dosubot
bot
added
size:XS
dosubot
bot
added
size:S
dosubot
bot
added
size:XS
EngHabu
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://flyte-org.slack.com/archives/CP2HDHKE1/p1708818106936209
Why are the changes needed?
Tasks are stuck in the queue phase when the resource quota is exceeded since the propeller won't send the event to Flyteadmin if the current phase is equal to the previous phase. Therefore, propeller won't update the state (
PhaseNotStarted->PhaseAllocationTokenAcquired) as well, and it will always assume that there is no resource available to execute the task.What changes were proposed in this pull request?
Change phase to WaitingForResources when the quota is exceeded, so propeller will send the event to flyteadmin.
How was this patch tested?
local sandbox and enable the resource manager
Setup process
Screenshots
Before:
After:
Related PRs
NA
Docs link
NA