Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add colon rule in version #5258

Merged
merged 3 commits into from Apr 21, 2024
Merged

[Docs] add colon rule in version #5258

merged 3 commits into from Apr 21, 2024

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Apr 21, 2024

Tracking issue

#4616

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <eric901201@gmail.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Apr 21, 2024
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier changed the title [Docs] add colon in version [Docs] add dns subdomain rule in version Apr 21, 2024
jasonlai1218
jasonlai1218 previously approved these changes Apr 21, 2024
Copy link
Contributor

@jasonlai1218 jasonlai1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2024
Signed-off-by: Future-Outlier <eric901201@gmail.com>
@Future-Outlier Future-Outlier changed the title [Docs] add dns subdomain rule in version [Docs] add colon rule in version Apr 21, 2024
@Future-Outlier Future-Outlier enabled auto-merge (squash) April 21, 2024 07:27
@Future-Outlier Future-Outlier merged commit 575a2a1 into master Apr 21, 2024
46 checks passed
@Future-Outlier Future-Outlier deleted the colon-version branch April 21, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants