Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunLLM Widget Configuration #5266

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Apr 22, 2024

Tracking issue

N/A

Why are the changes needed?

This pull request adds the necessary scripts to add the RunLLM widget to the Flyte documentation.

What changes were proposed in this pull request?

Includes a script tag in the base template.

How was this patch tested?

This code was tested on a Github Codespace. To test changes, I built the project and served it to myself with a simple http server to verify that the static site bundle works properly.

Screenshots

floatingUI

initial

opened

^ Once all the plumbing is hooked up on our backend this error should go away.

After configuring things on our end, here is a screenshot of the widget in action running against a staging deployment:

image

Copy link

welcome bot commented Apr 22, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Apr 22, 2024
Signed-off-by: Andre Giron <agiron123@gmail.com>
@cw75
Copy link

cw75 commented Apr 22, 2024

@davidmirror-ops this is the chat widget PR.

Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small change requested.

@@ -75,6 +75,14 @@
{%- block extra_styles -%}
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@docsearch/css@3" />
<link rel="preconnect" href="https://WLG0MZB58Q-dsn.algolia.net" crossorigin />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be moved below the {%- block extrahead -%}{%- endblock -%} line (currently line 91 in this PR). Currently this is inside the extra_styles block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I'll get this updated.

Signed-off-by: Andre Giron <agiron123@gmail.com>
…inked to.

Signed-off-by: Andre Giron <agiron123@gmail.com>
Signed-off-by: Andre Giron <agiron123@gmail.com>
@davidmirror-ops davidmirror-ops merged commit 8c5aac6 into flyteorg:master Apr 23, 2024
46 checks passed
Copy link

welcome bot commented Apr 23, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants