-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade actions/checkout #5294
Upgrade actions/checkout #5294
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5294 +/- ##
=======================================
Coverage 60.19% 60.19%
=======================================
Files 646 646
Lines 45654 45654
=======================================
Hits 27481 27481
Misses 15581 15581
Partials 2592 2592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -21,7 +21,9 @@ jobs: | |||
|
|||
steps: | |||
- name: Checkout | |||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3 and v2 is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally, I try to use the default force-depth: 1
and only use force-depth: 0
when the GitHub Action requires it. For this PR, can we only set force-depth: 0
for the jobs that failed on the CI logs?
Can we not use |
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Tracking issue
NA
Why are the changes needed?
Upgrade actions/checkout and set fetch-depth to 0 to fix the CI error.
https://github.com/flyteorg/flyte/actions/runs/8876065707/job/24366874983?pr=5126