Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions/checkout #5294

Merged
merged 5 commits into from
May 1, 2024
Merged

Upgrade actions/checkout #5294

merged 5 commits into from
May 1, 2024

Conversation

pingsutw
Copy link
Member

Tracking issue

NA

Why are the changes needed?

Upgrade actions/checkout and set fetch-depth to 0 to fix the CI error.

https://github.com/flyteorg/flyte/actions/runs/8876065707/job/24366874983?pr=5126

Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw marked this pull request as draft April 29, 2024 10:34
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.19%. Comparing base (5470f3f) to head (1548789).
Report is 362 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5294   +/-   ##
=======================================
  Coverage   60.19%   60.19%           
=======================================
  Files         646      646           
  Lines       45654    45654           
=======================================
  Hits        27481    27481           
  Misses      15581    15581           
  Partials     2592     2592           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.78% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw marked this pull request as ready for review April 30, 2024 02:32
@@ -21,7 +21,9 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3 and v2 is deprecated

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, I try to use the default force-depth: 1 and only use force-depth: 0 when the GitHub Action requires it. For this PR, can we only set force-depth: 0 for the jobs that failed on the CI logs?

@eapolinario
Copy link
Contributor

Can we not use force-depth: 0? Essentially just move to v4, since the original failure in the PR description was fixed by #5298.

Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw merged commit 88a2f50 into master May 1, 2024
49 checks passed
@pingsutw pingsutw deleted the upgrad-action branch May 1, 2024 00:29
austin362667 pushed a commit to austin362667/flyte that referenced this pull request May 7, 2024
Signed-off-by: Kevin Su <pingsutw@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants