Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(databricks): support override Databricks instances #5358

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pingsutw
Copy link
Member

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw marked this pull request as draft May 13, 2024 15:26
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 37.53%. Comparing base (2f38d65) to head (9c66353).
Report is 108 commits behind head on master.

Files Patch % Lines
...ugins/go/tasks/plugins/webapi/databricks/plugin.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5358       +/-   ##
===========================================
- Coverage   61.09%   37.53%   -23.56%     
===========================================
  Files         794     1301      +507     
  Lines       51213   112713    +61500     
===========================================
+ Hits        31288    42306    +11018     
- Misses      17044    66234    +49190     
- Partials     2881     4173     +1292     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (-17.95%) ⬇️
unittests-flyteadmin 55.56% <ø> (-3.31%) ⬇️
unittests-flytecopilot 12.17% <ø> (-5.62%) ⬇️
unittests-flytectl 65.68% <ø> (-2.62%) ⬇️
unittests-flyteidl 7.32% <ø> (-71.98%) ⬇️
unittests-flyteplugins 54.94% <88.88%> (-7.01%) ⬇️
unittests-flytepropeller 42.91% <ø> (-14.41%) ⬇️
unittests-flytestdlib 55.79% <ø> (-9.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw closed this Jul 23, 2024
@pingsutw pingsutw reopened this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant