removed unused

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
flyteorg · Apr 8, 2022 · 47bb2ec · 47bb2ec
1 parent b0cde31
commit 47bb2ec
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/pkg/common/sorting.go b/pkg/common/sorting.go
@@ -17,7 +17,6 @@ type SortParameter interface {
 
 type sortParamImpl struct {
 	gormOrderExpression string
-	sortKey             string
 }
 
 func (s *sortParamImpl) GetGormOrderExpr() string {

diff --git a/pkg/repositories/gormimpl/named_entity_repo.go b/pkg/repositories/gormimpl/named_entity_repo.go
@@ -38,13 +38,8 @@ func getSubQueryJoin(db *gorm.DB, tableName string, input interfaces.ListNamedEn
 
 	// Apply consistent sort ordering.
 	if input.SortParameter != nil {
-		//identifierGroupByWithOrderKey := fmt.Sprintf("%s, %s, %s, %s", Project, Domain, Name, input.SortParameter.GetSortKey())
-		//tx = tx.Group(identifierGroupByWithOrderKey)
 		tx = tx.Order(input.SortParameter.GetGormOrderExpr())
 	}
-	//else {
-	//	tx = tx.Group(identifierGroupBy)
-	//}
 
 	return db.Joins(fmt.Sprintf(joinString, input.ResourceType), tx)
 }