Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Adding back auth role #407

Merged
merged 1 commit into from Apr 15, 2022
Merged

Adding back auth role #407

merged 1 commit into from Apr 15, 2022

Conversation

pmahindrakar-oss
Copy link
Contributor

Signed-off-by: Prafulla Mahindrakar prafulla.mahindrakar@gmail.com

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #407 (62ceb8f) into master (3c29b17) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   61.05%   61.15%   +0.10%     
==========================================
  Files         154      154              
  Lines       11081    11088       +7     
==========================================
+ Hits         6765     6781      +16     
+ Misses       3608     3601       -7     
+ Partials      708      706       -2     
Flag Coverage Δ
unittests 60.10% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/manager/impl/execution_manager.go 74.34% <100.00%> (+0.31%) ⬆️
pkg/workflowengine/impl/prepare_execution.go 87.50% <100.00%> (+2.50%) ⬆️
dataproxy/service.go 38.18% <0.00%> (-0.71%) ⬇️
...implementations/workflow_execution_event_writer.go 80.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c29b17...62ceb8f. Read the comment docs.

@katrogan katrogan merged commit 2c7c541 into master Apr 15, 2022
@katrogan katrogan deleted the pmahindrakar/bring-back-authrole branch April 15, 2022 16:51
alexapdev pushed a commit to alexapdev/flyteadmin that referenced this pull request Apr 20, 2022
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Signed-off-by: Alex Pozimenko <alex.pozimenko@woven-planet.global>
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants