Tracking reasons time-series #540
Conversation
Signed-off-by: Daniel Rammer <daniel@union.ai>
| @@ -151,6 +151,15 @@ func CreateTaskExecutionModel(ctx context.Context, input CreateTaskExecutionMode | |||
| EventVersion: input.Request.Event.EventVersion, | |||
| } | |||
|
|
|||
| if len(input.Request.Event.Reason) > 0 { | |||
There was a problem hiding this comment.
is this right? should it not check for len(closure.Reasons) <= 0
There was a problem hiding this comment.
so this is run in CreateTaskExecutionModel so closure.Reasons will always be 0 because we just created the closure. This just says - don't add a reason to the time-series if the reason is an empty string.
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
hamersaw
requested review from
katrogan,
wild-endeavor,
EngHabu,
pmahindrakar-oss and
eapolinario
as code owners
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
+ Coverage 60.18% 61.72% +1.54%
==========================================
Files 169 169
Lines 15106 12437 -2669
==========================================
- Hits 9091 7677 -1414
+ Misses 5214 3959 -1255
Partials 801 801
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 154 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* tracking reasons time-series Signed-off-by: Daniel Rammer <daniel@union.ai> * bumped flyteidl dep and added comment Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai>
TL;DR
This PR populates the new
Reasonsfield on theTaskExecutionClosureto track a reason time-series. This will be very useful in improving visualizations by tracking the reason for task phase transitions and updates.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3501
Follow-up issue
NA