This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Address resolution #546
Merged
Address resolution #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
kumare3
reviewed
Apr 21, 2023
kumare3
reviewed
Apr 21, 2023
kumare3
reviewed
Apr 21, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
requested review from
katrogan,
EngHabu,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
+ Coverage 58.85% 60.49% +1.64%
==========================================
Files 170 172 +2
Lines 16068 13303 -2765
==========================================
- Hits 9457 8048 -1409
+ Misses 5777 4409 -1368
- Partials 834 846 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8 tasks
EngHabu
reviewed
May 2, 2023
| taskExecs, err := s.taskExecutionManager.ListTaskExecutions(ctx, admin.TaskExecutionListRequest{ | ||
| NodeExecutionId: &nodeExecID, | ||
| Limit: 1, | ||
| Filters: fmt.Sprintf("eq(retry_attempt,%s)", strconv.Itoa(attempt)), |
There was a problem hiding this comment.
Is there a strongly typed way of doing this?
There was a problem hiding this comment.
not really... i think we should punt on this.
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
EngHabu
previously approved these changes
May 5, 2023
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
EngHabu
approved these changes
May 5, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add logic to return and accept
flyte://when getting dataType
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Related to: flyteorg/flyteidl#391