Code Coverage published to codecov.io #61
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
Coverage ? 57.23%
=========================================
Files ? 362
Lines ? 5745
Branches ? 789
=========================================
Hits ? 3288
Misses ? 2457
Partials ? 0 Continue to review full report at Codecov.
|
|
|
||
| .PHONY: test_unit_codecov | ||
| test_unit_codecov: test_unit | ||
| npm install codecov -g |
There was a problem hiding this comment.
This should just be added to the project dependencies, not installed every time we run make. Also, we use yarn for dependency management. Using npm here will probably generate a separate lock file that is incompatible with our yarn lockfile.
| .PHONY: test_unit_codecov | ||
| test_unit_codecov: test_unit | ||
| npm install codecov -g | ||
| codecov -f .coverage/coverage-final.json |
There was a problem hiding this comment.
This doesn't appear to actually run the unit tests anymore, just generates code coverage. I think we need something like yarn test && yarn run codecov.
There was a problem hiding this comment.
Nvmd, I missed that it has a dependency on the other make target
| @@ -20,7 +20,7 @@ | |||
| "start": "node -r dotenv/config index.js", | |||
| "storybook": "start-storybook -p 9001 -c .storybook", | |||
| "tdd": "yarn run test --watch --verbose false", | |||
| "test": "NODE_ENV=test jest --config=jest.config.js" | |||
| "test": "NODE_ENV=test jest --coverage --config=jest.config.js" | |||
There was a problem hiding this comment.
Generating coverage is a lot slower than just running the tests. I would recommend we create a separate script here just to run code coverage, and not run it every time unit tests are run.
TL;DR
The PR publishes test coverage report to codecov.io. This allows tracking every checkin and the code coverage over time
Type
Are all requirements met?
Complete description
Same as TL;DR
Tracking Issue
flyteorg/flyte#260
Follow-up issue
NA