Perf Refactor: Some parent nodes don't load children #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olga-union
reviewed
Feb 7, 2023
| for (const executionId in allExecutions) { | ||
| const execution = allExecutions[executionId]; |
There was a problem hiding this comment.
let's keep the dynamicExecution name, so we don't trigger the changes here, and executionsByNodeId can be transformed to dynamicExecutionsByNodeId
There was a problem hiding this comment.
@olga-union. As this execution can be dynamic or static, so I don't think we can name it as dynamicExecution.
jsonporter
approved these changes
Feb 9, 2023
jsonporter
pushed a commit
that referenced
this pull request
Feb 14, 2023
fix: checkForDynamicExecutions Signed-off-by: Jason Porter <jason@union.ai>
jsonporter
added a commit
that referenced
this pull request
Feb 14, 2023
* fix: execution view children fetch on demand refactor Signed-off-by: Olga Nad <olga@union.ai> Signed-off-by: Jason Porter <jason@union.ai> * fix: incorrect import Signed-off-by: Olga Nad <olga@union.ai> Signed-off-by: Jason Porter <jason@union.ai> * chore: fix expander bug (#677) * chore: fix expander bug Signed-off-by: Carina Ursu <carina@union.ai> * chore: add await everywhere Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: Jason Porter <jason@union.ai> * fix: toggle in timeline Signed-off-by: Olga Nad <olga@union.ai> Signed-off-by: Jason Porter <jason@union.ai> * fix: checkForDynamicExecutions Signed-off-by: Jason Porter <jason@union.ai> * Revert "fix: checkForDynamicExecutions" This reverts commit 450d144. Signed-off-by: Jason Porter <jason@union.ai> * Perf Refactor: Some parent nodes don't load children (#680) fix: checkForDynamicExecutions Signed-off-by: Jason Porter <jason@union.ai> * chore: simplify graph code Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: Jason Porter <jason@union.ai> * adding util Signed-off-by: Jason Porter <jason@union.ai> * Changing type Signed-off-by: Jason Porter <jason@union.ai> * Updated click handlers Signed-off-by: Jason Porter <jason@union.ai> * Fixed graph dynamic node issue Signed-off-by: Jason Porter <jason@union.ai> * Key was not a valid prop in this case, removed Signed-off-by: Jason Porter <jason@union.ai> * chore: fix tests Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: Jason Porter <jason@union.ai> --------- Signed-off-by: Olga Nad <olga@union.ai> Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: Carina Ursu <carina@union.ai> Co-authored-by: Carina Ursu <carina@union.ai> Co-authored-by: James <james@union.ai> Co-authored-by: james-union <105876962+james-union@users.noreply.github.com> Co-authored-by: Jason Porter <jason@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/unionai/cloud/issues/1645
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/