fix: type error on invalid nested json input #693

4nalog · 2023-03-01T14:47:29Z

TL;DR

This PR fixes the parseJson utility function that maps inputs to a JSON form to handle situations when a nested object is optional or has value of null.

Type

Bug Fix
Feature
Plugin

Are all requirements met?

Complete description

fix: parseJson helper function does not handle null values

Tracking Issue

fixes flyteorg/flyte#3157

Follow-up issue

NA

codecov · 2023-03-08T15:29:17Z

Codecov Report

Merging #693 (4f598e9) into master (ca1b5b8) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   66.74%   66.73%   -0.02%     
==========================================
  Files         464      464              
  Lines       11388    11390       +2     
  Branches     2102     2104       +2     
==========================================
  Hits         7601     7601              
- Misses       3787     3789       +2

Impacted Files	Coverage Δ
...e/src/components/Launch/LaunchForm/StructInput.tsx	`54.34% <0.00%> (-2.48%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jsonporter · 2023-03-21T20:18:33Z

packages/console/src/components/Launch/LaunchForm/StructInput.tsx

-    if (keys[0]) {
+    if (keys.length > 1) {
+      // If there are multiple keys, we can't render a form because of not supporting nested structs
+      jsonFormRenderable = false;


I think we want to render a free-form text area in this case; they can paste in JSON?

Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: launchform Signed-off-by: James <james@union.ai> * fix: stuck issue Signed-off-by: James <james@union.ai> * fix: on form change Signed-off-by: James <james@union.ai> * fix: merge master into branch Signed-off-by: James <james@union.ai> --------- Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: project settings dashbboard tests Signed-off-by: 4nalog <4nalog@protonmail.com> * chore: remove .only Signed-off-by: 4nalog <4nalog@protonmail.com> * refactor: remove empty waitFor Signed-off-by: 4nalog <4nalog@protonmail.com> --------- Signed-off-by: 4nalog <4nalog@protonmail.com>

Upgrading node version to 18 Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: revert node version Signed-off-by: Carina Ursu <carina@union.ai> * Revert "fix: upgrading node version to 18 (#703)" This reverts commit e5f9a8b. Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: deployment optimization Signed-off-by: Carina Ursu <carina@union.ai> * clean up node modules and one file that we think is not needed Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: fix update_npmversion Signed-off-by: Carina Ursu <carina@union.ai> * chore: edits Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: cache status logs indexing mismatch and react rendering cycle issue Signed-off-by: James <james@union.ai> * fix: mapped task cache status Signed-off-by: James <james@union.ai> --------- Signed-off-by: James <james@union.ai> Co-authored-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: passthrough runtime variables Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: nodejs 18 upgrade Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: allow complex workflow names Signed-off-by: Carina Ursu <carina@union.ai> * chore: fix buold:watch Signed-off-by: Carina Ursu <carina@union.ai> * chore: yarn.lock Signed-off-by: Carina Ursu <carina@union.ai> * chore: upgrade package Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai>

* chore: show correct app version in info Signed-off-by: Carina Ursu <carina@union.ai> * chore: update ver Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: add icon for put failure Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: add material-ui class name seed Signed-off-by: Carina Ursu <carina@union.ai> * fix: overflow of modal Signed-off-by: James <james@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: James <james@union.ai> Co-authored-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

… correctly (#723) fix: dynamic nodes status Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: backfill index on execution task logs Signed-off-by: Carina Ursu <carina@union.ai> * chore: add comments Signed-off-by: Carina Ursu <carina@union.ai> * chore: bump version Signed-off-by: Carina Ursu <carina@union.ai> * chore: remove backfill Signed-off-by: Carina Ursu <carina@union.ai> * chore: lint Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com> Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: show correct i/o in details panel Signed-off-by: Carina Ursu <carina@union.ai> * chore: bump version Signed-off-by: Carina Ursu <carina@union.ai> * chore: feedback Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: tlro basic setup Signed-off-by: Carina Ursu <carina@union.ai> * progress checkin * Stable state refactored to use generic naming * updated types * working before updating routes * chore: progress Signed-off-by: Carina Ursu <carina@union.ai> * chore: remove debugger Signed-off-by: Carina Ursu <carina@union.ai> * chore: allow custom class in execution actions Signed-off-by: Carina Ursu <carina@union.ai> * chore: lint fix Signed-off-by: Carina Ursu <carina@union.ai> * chore: bump console Signed-off-by: Carina Ursu <carina@union.ai> * chore: up package version Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Co-authored-by: Jason Porter <jason@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* chore: fix contextual menu action buttons color Signed-off-by: Carina Ursu <carina@union.ai> * chore: up console version Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: approveCondition reject Signed-off-by: James <james@union.ai> * fix: approve button Signed-off-by: James <james@union.ai> --------- Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

* fix: gate node in dynamic Signed-off-by: James <james@union.ai> * fix: upgraded version Signed-off-by: James <james@union.ai> * fix: compiledNode in PausedTasksComponent and ExecutionDetailsActions Signed-off-by: James <james@union.ai> * fix: upgrade version Signed-off-by: James <james@union.ai> * chore: lockfile Signed-off-by: Carina Ursu <carina@union.ai> * fix: remove caching for workflow closure Signed-off-by: James <james@union.ai> * fix: break link between cache and context state Signed-off-by: James <james@union.ai> --------- Signed-off-by: James <james@union.ai> Signed-off-by: Carina Ursu <carina@union.ai> Co-authored-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Signed-off-by: 4nalog <4nalog@protonmail.com>

…fix-type-error-on-invalid-json-input

flyte-bot · 2023-03-30T20:36:04Z

🎉 This PR is included in version 1.5.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

4nalog changed the title ~~[WIP] fix: type error on invalid nested json input~~ fix: type error on invalid nested json input Mar 2, 2023

4nalog marked this pull request as ready for review March 2, 2023 15:23

4nalog requested a review from jsonporter March 2, 2023 15:23

jsonporter reviewed Mar 21, 2023

View reviewed changes

4nalog force-pushed the soham/fix-type-error-on-invalid-json-input branch from bafe0c7 to 1f3e7db Compare March 30, 2023 18:35

4nalog and others added 24 commits March 30, 2023 14:47

fix: type error on invalid nested json input

303562a

Signed-off-by: 4nalog <4nalog@protonmail.com>

chore: bump minor version

0636f14

Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: package version to 1.4.2 (#700)

0aa8077

Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: upgrading node version to 18 (#703)

91567cb

Upgrading node version to 18 Signed-off-by: Jason Porter <jason@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: upgrade release node version (#707)

b2a7529

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: update chalk, add semantic-release test cmd (#708)

30c6c7f

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

chore: implement logic to handle multiple keys for nested data classes

ed495bb

Signed-off-by: 4nalog <4nalog@protonmail.com>

chore: fix update_npmversion (#709)

50309ba

* chore: fix update_npmversion Signed-off-by: Carina Ursu <carina@union.ai> * chore: edits Signed-off-by: Carina Ursu <carina@union.ai> --------- Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: cleanup, passthrough runtime variables (#710)

e08f7e4

fix: passthrough runtime variables Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: update_npmversion (#713)

19895c5

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: fix sed makefile error (#714)

e78a106

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

FE: Update flyteconsole to Node 18 (#717)

c9700ba

fix: nodejs 18 upgrade Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: left nav doesn't accurately update on workflow version page (#718)

997ce2c

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

feat: differentiate between cache disabled and cache put failure (#719)

41a5562

fix: add icon for put failure Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

chore: fix formatting

7035652

Signed-off-by: 4nalog <4nalog@protonmail.com>

The rendering of node status in a dynamic workflow is not functioning…

45c6386

… correctly (#723) fix: dynamic nodes status Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

ursucarina and others added 10 commits March 30, 2023 14:48

fix: release fail (#726)

7d2b69f

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Install deps directly in checks.yml (#728)

ddae902

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com> Signed-off-by: 4nalog <4nalog@protonmail.com>

chore: add build:watch to all packages (#731)

26600f6

Signed-off-by: Carina Ursu <carina@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

Add REJECT support for ApprovedCondition for GateNodes (#733)

77932de

* fix: approveCondition reject Signed-off-by: James <james@union.ai> * fix: approve button Signed-off-by: James <james@union.ai> --------- Signed-off-by: James <james@union.ai> Signed-off-by: 4nalog <4nalog@protonmail.com>

fix: comments

9423239

Signed-off-by: 4nalog <4nalog@protonmail.com>

4nalog force-pushed the soham/fix-type-error-on-invalid-json-input branch from 7a9577b to 9423239 Compare March 30, 2023 18:48

Merge branch 'master' of github.com:flyteorg/flyteconsole into soham/…

4f598e9

…fix-type-error-on-invalid-json-input

4nalog requested a review from jsonporter March 30, 2023 18:49

jsonporter approved these changes Mar 30, 2023

View reviewed changes

jsonporter merged commit c82e755 into master Mar 30, 2023

jsonporter deleted the soham/fix-type-error-on-invalid-json-input branch March 30, 2023 20:21

flyte-bot added the released label Mar 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: type error on invalid nested json input #693

fix: type error on invalid nested json input #693

4nalog commented Mar 1, 2023 •

edited

Loading

codecov bot commented Mar 8, 2023 •

edited

Loading

jsonporter Mar 21, 2023

flyte-bot commented Mar 30, 2023

fix: type error on invalid nested json input #693

fix: type error on invalid nested json input #693

Conversation

4nalog commented Mar 1, 2023 • edited Loading

TL;DR

Type

Are all requirements met?

Complete description

Tracking Issue

Follow-up issue

codecov bot commented Mar 8, 2023 • edited Loading

Codecov Report

jsonporter Mar 21, 2023

Choose a reason for hiding this comment

flyte-bot commented Mar 30, 2023

4nalog commented Mar 1, 2023 •

edited

Loading

codecov bot commented Mar 8, 2023 •

edited

Loading