Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [tlm] comprehensive node execution query #749

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Conversation

ursucarina
Copy link
Contributor

TL;DR

Adds a node execution query that also fetches tasks and task closures

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Adds a node execution query that also fetches tasks and task closures

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and olga-union and removed request for a team April 26, 2023 06:34
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
Signed-off-by: Carina Ursu <carina@union.ai>
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #749 (1ef495b) into master (e4919df) will increase coverage by 0.12%.
The diff coverage is 49.47%.

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   66.40%   66.53%   +0.12%     
==========================================
  Files         475      485      +10     
  Lines       11714    11770      +56     
  Branches     2155     2162       +7     
==========================================
+ Hits         7779     7831      +52     
- Misses       3935     3939       +4     
Impacted Files Coverage Δ
packages/console/src/components/Errors/index.ts 0.00% <0.00%> (ø)
...eExecutionDetails/NodeExecutionDynamicProvider.tsx 87.71% <ø> (-0.22%) ⬇️
...xecutionDetails/WorkflowNodeExecutionsProvider.tsx 90.42% <ø> (+2.12%) ⬆️
...ages/console/src/components/Executions/contexts.ts 42.85% <ø> (ø)
...ackages/console/src/components/Executions/utils.ts 71.17% <ø> (ø)
.../console/src/components/Launch/LaunchForm/index.ts 0.00% <0.00%> (ø)
packages/console/src/components/Launch/index.ts 0.00% <0.00%> (ø)
packages/console/src/components/Task/index.ts 0.00% <0.00%> (ø)
packages/console/src/components/Workflow/index.ts 0.00% <0.00%> (ø)
...ponents/WorkflowGraph/transformerWorkflowToDag.tsx 49.35% <ø> (ø)
... and 20 more

... and 3 files with indirect coverage changes

@jsonporter jsonporter merged commit 8f8d686 into master Apr 28, 2023
10 of 11 checks passed
@jsonporter jsonporter deleted the carina/tlm branch April 28, 2023 17:07
ursucarina added a commit that referenced this pull request May 10, 2023
* chore: comprehensive node execution query

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: fix graph render bug

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: test fixes

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: additions

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: build fix?

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants