Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
FrankFlitton
force-pushed
the
bug-fix-launch-plan-execution-detail-page-back-button
branch
from
cd6b82d
to
2154eab
Compare
Signed-off-by: Frank Flitton <fflitton@gmail.com>
FrankFlitton
force-pushed
the
bug-fix-launch-plan-execution-detail-page-back-button
branch
from
2154eab
to
9c57fdf
Compare
ursucarina
requested review from
a team,
ursucarina,
jsonporter and
socalledso
and removed request for
a team
|
Nice work adding the extra tests 💯 |
ursucarina
previously approved these changes
May 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
=======================================
Coverage 65.90% 65.90%
=======================================
Files 489 489
Lines 11917 11918 +1
Branches 2198 2198
=======================================
+ Hits 7854 7855 +1
Misses 4063 4063
|
socalledso
reviewed
May 17, 2023
| @@ -1,7 +1,7 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
I see in some places we use import * as React but in other we use import React from "react".
Probably we dont need the * as react anymore?
socalledso
previously approved these changes
May 17, 2023
Signed-off-by: Frank Flitton <fflitton@gmail.com>
FrankFlitton
force-pushed
the
bug-fix-launch-plan-execution-detail-page-back-button
branch
from
f6cd482
to
a191e04
Compare
ursucarina
approved these changes
May 17, 2023
|
Congrats on merging your first pull request! 🎉 |
wild-endeavor
added a commit
to flyteorg/flyte
that referenced
this pull request
May 22, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> ### Admin - v1.1.100 * Inject user identifier to ExecutionSpec by @ByronHsu in flyteorg/flyteadmin#549 * Fix flaky test by @eapolinario in flyteorg/flyteadmin#563 * Add oauth http proxy for external server & Extract email from azure claim by @ByronHsu in flyteorg/flyteadmin#553 * Remove single task execution default timeout by @hamersaw in flyteorg/flyteadmin#564 * Revert conditional setting of SecurityContext when launching security context by @wild-endeavor in flyteorg/flyteadmin#566 ### Console - v1.8.2 * Export Flytedecks support for TLRO by @james-union in flyteorg/flyteconsole#757 * fix: filter executions by version and name by @ursucarina in flyteorg/flyteconsole#758 * fix: task recent runs should filter by version by @ursucarina in flyteorg/flyteconsole#759 * Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch by @FrankFlitton in flyteorg/flyteconsole#760 * chore: add item when mapped task by @jsonporter in flyteorg/flyteconsole#761 * Feature: Fullview Flyte Deck modal by @FrankFlitton in flyteorg/flyteconsole#764 ### Propeller - v1.1.90 * Add grpc plugin to loader.go by @pingsutw in flyteorg/flytepropeller#562
|
🎉 This PR is included in version 1.8.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixes routing behaviour for back arrow button for Launch Plans workflow execution detail referred pages.
Type
Are all requirements met?
Complete description
Added
fromLinkto routerstateto use existing logic to match other workflow tables.Follow-up issue
NA