Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: launch plan icon #777

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: launch plan icon #777

merged 1 commit into from
Jun 21, 2023

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Jun 20, 2023

TL;DR

Fixes Launch plan icon to:

  • respect selected color
  • remove additional margins in side nav

Before:
image

After:
image

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Fixes Launch plan icon to:

  • respect selected color
  • remove additional margins in side nav

Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina requested review from a team, jsonporter, socalledso and james-union and removed request for a team June 20, 2023 18:09
@ursucarina ursucarina enabled auto-merge (squash) June 20, 2023 18:16
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #777 (bed0b4b) into master (4783c39) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   65.80%   65.80%           
=======================================
  Files         491      491           
  Lines       11997    11997           
  Branches     2225     2225           
=======================================
  Hits         7895     7895           
  Misses       4102     4102           
Impacted Files Coverage Δ
...onents/LaunchPlan/SearchableLaunchPlanNameList.tsx 0.00% <ø> (ø)
...le/src/components/Navigation/ProjectNavigation.tsx 0.00% <0.00%> (ø)

@ursucarina ursucarina merged commit 4b57956 into master Jun 21, 2023
11 of 12 checks passed
@ursucarina ursucarina deleted the carina/lpicon branch June 21, 2023 15:51
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants