Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Bumping go version to 1.19 #45

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Feb 8, 2023

TL;DR

Bumping the go version to 1.19 to fix pull request checks.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
@welcome
Copy link

welcome bot commented Feb 8, 2023

Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #45 (5949781) into master (378c9d2) will decrease coverage by 0.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   17.79%   16.87%   -0.92%     
==========================================
  Files           3        3              
  Lines         399      474      +75     
==========================================
+ Hits           71       80       +9     
- Misses        315      381      +66     
  Partials       13       13              
Flag Coverage Δ
unittests 16.87% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data/utils.go 64.91% <0.00%> (-5.31%) ⬇️
data/upload.go 31.15% <0.00%> (-1.32%) ⬇️
data/download.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, not blocking the PR.

Dockerfile Show resolved Hide resolved
@hamersaw hamersaw merged commit 97772fd into master Feb 9, 2023
@welcome
Copy link

welcome bot commented Feb 9, 2023

Congrats on merging your first pull request! 🎉

@hamersaw hamersaw deleted the housekeeping/bump-go-version branch February 9, 2023 15:46
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* bumping go version to 1.19

Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>

* updated dockerfile

Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>

---------

Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants