Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Remove dependency on unsupported k8s.io/kubernetes library #457

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

katrogan
Copy link
Contributor

TL;DR

See kubernetes/kubernetes#79384 (comment) for background,

use of packages within the k8s.io/kubernetes module as a library/dependency is unsupported and not recommended.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@katrogan katrogan changed the title Remove dependency on unsupported library Remove dependency on unsupported k8s.io/kubernetes library Jan 22, 2024
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35de5b8) 67.70% compared to head (3c6dafa) 67.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   67.70%   67.69%   -0.01%     
==========================================
  Files         148      148              
  Lines        6641     6639       -2     
==========================================
- Hits         4496     4494       -2     
  Misses       1855     1855              
  Partials      290      290              
Flag Coverage Δ
unittests 67.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wild-endeavor
wild-endeavor previously approved these changes Jan 22, 2024
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
wild-endeavor
wild-endeavor previously approved these changes Jan 22, 2024
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@katrogan katrogan merged commit 79ed5ce into master Jan 22, 2024
14 of 15 checks passed
@katrogan katrogan deleted the kubernetes.io branch January 22, 2024 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants