This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Introduce TypeAnnotation#minor #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Kenny Workman <kennyworkman@sbcglobal.net>
EngHabu
previously approved these changes
Nov 30, 2021
|
sounds good |
Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Kenny Workman <kennyworkman@sbcglobal.net>
8 tasks
7 tasks
Signed-off-by: Kenny Workman <kennyworkman@sbcglobal.net>
kennyworkman
force-pushed
the
master
branch
2 times, most recently
from
8c4bb8c
to
17fc33f
Compare
eapolinario
approved these changes
Feb 7, 2022
EngHabu
approved these changes
Feb 8, 2022
|
Congrats on merging your first pull request! 🎉 |
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* feat: introduce TypeAnnotation Signed-off-by: Kenny Workman <kennyworkman@sbcglobal.net> * fix: message description Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Kenny Workman <kennyworkman@sbcglobal.net> * fix: regen proto after merge Signed-off-by: Kenny Workman <kennyworkman@sbcglobal.net> Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read then delete this section
- Make sure to use a concise title for the pull-request.
- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details
TL;DR
Introduce new message to idl for typing annotations re: flyteorg/flyte#1855
Type
Are all requirements met?
Complete description
flyteorg/flyte#1855