This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: buf integration for proto release #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
+ Coverage 74.77% 75.02% +0.25%
==========================================
Files 15 15
Lines 991 993 +2
==========================================
+ Hits 741 745 +4
+ Misses 218 217 -1
+ Partials 32 31 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com>
Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com>
katrogan
previously approved these changes
Jun 2, 2022
Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com>
pmahindrakar-oss
approved these changes
Jun 3, 2022
EngHabu
approved these changes
Jun 3, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
* fix: integrated buf Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com> * added protoc-gen-swagger Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com> * buf mod update Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com> * fix proto path in ci Signed-off-by: Yuvraj <evalsocket@users.noreply.github.com> Co-authored-by: Yuvraj <evalsocket@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
NOTE:
Registry: https://buf.build/flyteorg/flyteidl/docs
Test: https://github.com/evalsocket/flyteidl/runs/6721291950?check_suite_focus=true
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes flyteorg/flyte#1096
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/