include node id for missing test double error messages for SdkTestExecutor #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 |
AndersonReyes
force-pushed
the
Testing-Errors-Nodeid
branch
from
ee1e28b
to
a83d2b1
Compare
Signed-off-by: Anderson Reyes <reyesanderson428@gmail.com> formatting
AndersonReyes
force-pushed
the
Testing-Errors-Nodeid
branch
from
490e073
to
7ed3513
Compare
|
llooks like it failed with but not sure what this error means, looking into it |
|
might have just been gh actions acting up |
RRap0so
approved these changes
Sep 26, 2023
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
Include the node id in the errors when there is no matching mock / test double for a node. This makes it easier to find the node / apply code when there might be mutiple instances of the same task.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/