Extract public #244
Merged
Extract public #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
honnix
force-pushed
the
extract-public
branch
from
5ed884e
to
db89324
Compare
bergman
reviewed
Sep 26, 2023
| @@ -0,0 +1,182 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright 2021 Flyte Authors. | |||
There was a problem hiding this comment.
Suggested change
| Copyright 2021 Flyte Authors. | |
| Copyright 2023 Flyte Authors. |
Unless there is some specific requirement that it this license section is the exact same everywhere?
There was a problem hiding this comment.
Line 415 in 04e6fdc
There was a problem hiding this comment.
Ah, I was afraid it was something like this. Thanks for confirming!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Extract jflyte utility classes into a separated module.
Type
Are all requirements met?
Complete description
This is to make it easier to extend jflyte or replacing certain subcommands, otherwise things have to be done in
org.flyte.jflytepackages.Note that not everything in jflyte-utils is public because we only want to open up things we know for sure are already being used and we can open up others when needed.
Tracking Issue
NA
Follow-up issue
NA