Fix license header #245
Merged
Fix license header #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
honnix
commented
Sep 26, 2023
| @@ -440,40 +440,13 @@ | |||
| </googleJavaFormat> | |||
| <removeUnusedImports /> | |||
| </java> | |||
| <xml> | |||
There was a problem hiding this comment.
I don't know how we came up with this <xml> configuration but it doesn't seems to be supported by spotless at all.
|
We could also retrospectively updating all headers according to git commit history but that would be a massive change. Do we want to do this? #246 It is also worth noting that spotless license header thing does not support |
honnix
commented
Sep 26, 2023
| @@ -418,7 +418,7 @@ | |||
| <licenseHeader> | |||
| <!-- Specify either content or file, but not both --> | |||
| <content><
andresgomezfrr
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix license header by using a year parameter
Type
Are all requirements met?
Complete description
With this, we will not be forced to use 2021 forever.
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
NA
Follow-up issue
NA