Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested list & map of structs using case classes #267

Merged
merged 3 commits into from Nov 23, 2023
Merged

Fix nested list & map of structs using case classes #267

merged 3 commits into from Nov 23, 2023

Conversation

andresgomezfrr
Copy link
Collaborator

@andresgomezfrr andresgomezfrr commented Nov 23, 2023 •
edited by honnix

TL;DR

Fix nested list of structs using scala layer.

case class ScalarNested(
    foo: String,
    bar: Option[String],
    nestedNested: Option[ScalarNestedNested],
    nestedNestedList: List[ScalarNestedNested], // <----- THIS
    nestedNestedMap: Map[String, ScalarNestedNested] // <----- THIS
)
case class ScalarNestedNested(foo: String, bar: Option[String])

support-nested-list-of-structs

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@andresgomezfrr
Fix nested list & map of structs
1e6fa65 
Signed-off-by: Andres Gomez Ferrer <andresg@spotify.com>
@andresgomezfrr andresgomezfrr changed the title Fix nested list of structs Fix nested list & map of structs Nov 23, 2023
@andresgomezfrr andresgomezfrr changed the title Fix nested list & map of structs Fix nested list & map of structs using case classes Nov 23, 2023
@andresgomezfrr
Rename value to v in lambdas
38edfc5 
Signed-off-by: Andres Gomez Ferrer <andresg@spotify.com>
@andresgomezfrr
Make it compatible with scala 2.12
96b61a1 
Signed-off-by: Andres Gomez Ferrer <andresg@spotify.com>
@andresgomezfrr andresgomezfrr merged commit acac5fe into master Nov 23, 2023
4 checks passed
@andresgomezfrr andresgomezfrr deleted the support-nested-list-of-structs branch November 23, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honnix honnix honnix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andresgomezfrr @honnix