Made outfile ephemeral

Signed-off-by: pryce-turner <pryce.turner@gmail.com>

flytekit/extras/tasks/shell.py

@@ -80,6 +80,8 @@ def subproc_execute(command: typing.Union[List[str], str], **kwargs) -> ProcessR
         # Execute the command and capture stdout and stderr
         result = subprocess.run(command, **kwargs)
 
+        assert result.stderr == ""
+
         # Access the stdout and stderr output
         return ProcessResult(result.returncode, result.stdout, result.stderr)
 
@@ -93,6 +95,9 @@ def subproc_execute(command: typing.Union[List[str], str], **kwargs) -> ProcessR
             custom dependencies?\n{e}"""
         )
 
+    except AssertionError:
+        raise Exception(f"Command: {command}\nexperienced a silent failure, likely due to shell=True:\n{result.stderr}")
+
 
 def _dummy_task_func():
     """

tests/flytekit/unit/extras/tasks/test_shell.py

@@ -370,3 +370,27 @@ def test_subproc_execute_with_shell():
         subproc_execute(cmd, shell=True)
         cont = open(opth).read()
         assert "hello" in cont
+
+
+def test_subproc_execute_missing_dep():
+    cmd = ["non-existent", "blah"]
+    with pytest.raises(Exception) as e:
+        subproc_execute(cmd)
+    assert "executable could not be found" in str(e.value)
+
+
+def test_subproc_execute_error():
+    cmd = ["ls", "--banana"]
+    with pytest.raises(Exception) as e:
+        subproc_execute(cmd)
+    assert "Failed with return code" in str(e.value)
+
+
+def test_subproc_execute_shell_error(tmp_path):
+    # This is a corner case I ran into that really shouldn't
+    # ever happen. The assert catches anything in stderr despite
+    # a 0 exit.
+    cmd = " ".join(["bcftools", "isec", "|", "gzip", "-c", ">", f"{tmp_path.joinpath('out')}"])
+    with pytest.raises(Exception) as e:
+        subproc_execute(cmd, shell=True)
+    assert "silent failure" in str(e.value)