Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass cluster pool when creating executions #1208

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

iaroslav-ciupin
Copy link
Contributor

@iaroslav-ciupin iaroslav-ciupin commented Sep 29, 2022

TL;DR

  • Allow passing cluster pool when running a workflow pyflyte run --remote --cluster-pool gpu my_wf.py

Type

  • Feature

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@welcome
Copy link

welcome bot commented Sep 29, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@iaroslav-ciupin iaroslav-ciupin force-pushed the create-execution-on-cluster-pool branch 2 times, most recently from 8e6b944 to fe5b6f1 Compare September 30, 2022 17:54
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Patch coverage: 52.63% and project coverage change: +0.01% 🎉

Comparison is base (716fde3) 20.11% compared to head (f95540d) 20.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
+ Coverage   20.11%   20.13%   +0.01%     
==========================================
  Files         337      337              
  Lines       32409    32427      +18     
  Branches     5854     5857       +3     
==========================================
+ Hits         6520     6530      +10     
- Misses      25723    25731       +8     
  Partials      166      166              
Files Changed Coverage Δ
flytekit/clis/sdk_in_container/run.py 0.00% <0.00%> (ø)
flytekit/clis/sdk_in_container/serve.py 0.00% <0.00%> (ø)
flytekit/remote/remote.py 21.08% <ø> (ø)
tests/flytekit/integration/remote/test_remote.py 0.00% <0.00%> (ø)
flytekit/models/execution.py 55.59% <62.50%> (+0.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
@iaroslav-ciupin iaroslav-ciupin force-pushed the create-execution-on-cluster-pool branch 2 times, most recently from 132c2cc to 9c3bcee Compare September 19, 2023 17:40
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
@iaroslav-ciupin iaroslav-ciupin merged commit af429f6 into master Sep 22, 2023
69 checks passed
@welcome
Copy link

welcome bot commented Sep 22, 2023

Congrats on merging your first pull request! 🎉

@iaroslav-ciupin iaroslav-ciupin deleted the create-execution-on-cluster-pool branch September 22, 2023 05:38
Future-Outlier pushed a commit to Future-Outlier/flytekit that referenced this pull request Oct 3, 2023
* Pass cluster pool when creating executions

Signed-off-by: Future Outlier <eric901201@gmai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
union-upstream Code that's also being used by Union
Projects
None yet
3 participants