-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build arm images #1305
Merged
Merged
Build arm images #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1305 +/- ##
=======================================
Coverage 68.87% 68.87%
=======================================
Files 287 287
Lines 26429 26429
Branches 2495 2495
=======================================
Hits 18202 18202
Misses 7743 7743
Partials 484 484 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eapolinario
reviewed
Nov 4, 2022
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
1db4ca8
to
b397a0d
Compare
wild-endeavor
approved these changes
Nov 4, 2022
wild-endeavor
approved these changes
Nov 4, 2022
eapolinario
reviewed
Nov 4, 2022
@@ -10,11 +10,14 @@ ENV PYTHONPATH /root | |||
ARG VERSION | |||
ARG DOCKER_IMAGE | |||
|
|||
RUN apt-get update && apt-get install build-essential -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could bring the builder back in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Build arm64 images for flytekit and sqlalchemy
Type
Are all requirements met?
Complete description
This change uses the
docker/build-push-action
and docker buildx multi-arch support to build images for amd64 and arm64 across all supported python versions.Verified images successfully build in forked repo with mock releases. See publish workflow and images.
Note: Looks like there is a dependency regression in master. Attempting to run tasks with these images fails with
I verified an amd64 image built from master is missing s3*
Tracking Issue
NA
Follow-up issue
NA