Update ray plugin dependency #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
wild-endeavor,
kumare3 and
eapolinario
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
+ Coverage 68.94% 69.04% +0.10%
==========================================
Files 291 291
Lines 26656 26699 +43
Branches 2508 2514 +6
==========================================
+ Hits 18377 18435 +58
+ Misses 7789 7772 -17
- Partials 490 492 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eapolinario
approved these changes
Dec 5, 2022
eapolinario
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario
added a commit
that referenced
this pull request
Feb 23, 2023
* Force flyteidl==1.2.9 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Sanitize query template input in sqlite task (#1359) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * TypeTransformer for reading and writing from TensorFlowRecord format (#1240) * first commit Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add tensorflow example tf record transformer Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * correct tfexample description Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix test_native.py Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add tensorflow docs and reqs Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add tensorflow docs and reqs1 Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * tensorflow import in init Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix failing tests Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add tensorflow pinned version to reqs Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * pin grpcio-status to remove protobuf error Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add suggested changes Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * redesign transformer Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * remove old script Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix type reference for TFREcordDataset Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * spacing and uppercase Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * redesign with tfdir and tfrecordfile subclass Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix conflicts and typos Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * address majority of comments Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix test with flytefile and metadata annotated Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix check for example records in directory Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor and correct typing Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * lint Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * import annotated from typing_extensions Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * tweak to tests to test case when Config not passed in as type Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add suggested changes Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add task for tfrecord dir with no config in test Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * get filenames from local dir instead of remote Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * update ray plugin dependency (#1361) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org> * Set default format of structured dataset to empty (#1159) * Set default format of structured dataset to empty Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * last error (#1364) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Adds CLI reference for pyflyte (#1362) * Adds pyflyte CLI reference guide Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * bump python version Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * bump python version Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * resolve docs error Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * set nested to none Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * remove flyteidl version constraint Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * update requirements Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * Signaling (#1133) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Adding created and updated at to ExecutionClosure model (#1371) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Add Databricks config to Spark Job (#1358) Signed-off-by: Kevin Su <pingsutw@apache.org> * Add overwrite_cache option the to calls of remote and local executions (#1375) Signed-off-by: H. Furkan Vural <hfurkanvural@blackshark.ai> Implemented cache overwrite feature is added on flytekit as well for the completeness. In order to support the cache eviction RFC, an overwrite parameter was added, indicating the data store should replace an existing artifact instead of creating a new one on local calls. * Remove project/domain from being overridden with execution values in serialized context (#1378) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Use TaskSpec instead of TaskTemplate for fetch_task and avoid network when loading module (#1348) Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Register Databricks config (#1379) * Register databricks plugin Signed-off-by: Kevin Su <pingsutw@apache.org> * Update databricks plugin Signed-off-by: Kevin Su <pingsutw@apache.org> * register databricks Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * PodSpec should not require primary_container name (#1380) For Pod tasks, if the primary_container_name is not specified, it should default. Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * fix(pyflyte): change -d to -D for --destination-dir as -d is already for --domain (#1381) Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> * Handle Optional[FlyteFile] in Dataclass type transformer (#1393) * Add support for Optional to dataclass transformer Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add one more test Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add one more test Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix serialization of optional flyte types Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * add FastSerializationSettings to docs (#1386) Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org> * Added more pod tests and an example pod task (#1382) * Added more pod tests and an example pod task Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * fixing test and name Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Convert default dict to json string in pyflyte run (#1399) Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> * docs: update register help, non-fast version is supported (#1402) Signed-off-by: Patrick Brogan <pbrogan12@gmail.com> * Update log level for structured dataset (#1394) Signed-off-by: Kevin Su <pingsutw@apache.org> * Add Niels to code owners (#1404) Signed-off-by: Kevin Su <pingsutw@apache.org> * Signal use (#1398) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * User Documentation Proposal (#1200) Signed-off-by: Kevin Su <pingsutw@apache.org> * Add support MLFlow plugin (#1274) * MLFlow plugin in progress Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * update test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update readme Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * dwip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * change experiment name Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * Add mlflow to index.rst Signed-off-by: Kevin Su <pingsutw@apache.org> * use experiment name that user provided Signed-off-by: Kevin Su <pingsutw@apache.org> * update doc-requirements.txt Signed-off-by: Kevin Su <pingsutw@apache.org> * Add backend plugin deployment Signed-off-by: Kevin Su <pingsutw@apache.org> * generate doc for method Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * update docstring Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update docstring Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * Update tracking.py Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> * fix remote API reference (#1405) Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * Read structured dataset from a folder (#1406) * Read polars dataframe in a folder Signed-off-by: Kevin Su <pingsutw@apache.org> * Read polars dataframe in a folder Signed-off-by: Kevin Su <pingsutw@apache.org> * Load huggingface and spark plugin implicitly Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * remove _pyspark alias Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Update default config to work out-of-the-box with flytectl demo (#1384) Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * Add dask plugin #patch (#1366) * Add dummy task type to test backend plugin Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add docs page Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add dask models Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add function to convert resources Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add tests to `dask` task Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Remove namespace Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update setup.py Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add dask to `plugin/README.md` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add README.md for `dask` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Top level export of `JopPodSpec` and `DaskCluster` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update docs for images Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update README.md Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update models after `flyteidl` change Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update task after `flyteidl` change Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Raise error when less than 1 worker Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update flyteidl to >= 1.3.2 Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update doc requirements Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update doc-requirements.txt Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Re-lock dependencies on linux Signed-off-by: Bernhard Stadlbauer <bernhard@pachama.com> * Update dask API docs Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Fix documentation links Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Default optional model constructor arguments to `None` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Refactor `convert_resources_to_resource_model` to `core.resources` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Use `convert_resources_to_resource_model` in `core.node` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Incorporate review feedback Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Lint Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> Signed-off-by: Bernhard Stadlbauer <bernhard@pachama.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add support for overriding task configurations (#1410) Signed-off-by: Kevin Su <pingsutw@apache.org> * Warning if git is not installed (#1414) * warning if git is not installed Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org> * Flip the settings for channel and logger (#1415) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Preserving Exception in the LazyEntity fetch (#1412) * Preserving Exception in the LazyEntity fetch Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated lint error Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * more tests Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * [Docs] SynchronousFlyteClient API reference #3095 (#1416) Signed-off-by: Peeter Piegaze <peeter@union.ai> Signed-off-by: Peeter Piegaze <peeter@union.ai> Co-authored-by: Peeter Piegaze <peeter@union.ai> Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com> * Return error code on fail (#1408) * AWS batch return error code once it fails Signed-off-by: Kevin Su <pingsutw@gmail.com> * AWS batch return error code once it fails Signed-off-by: Kevin Su <pingsutw@gmail.com> * update tests Signed-off-by: Kevin Su <pingsutw@gmail.com> * Update tests Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> * wrapping flyte entity in a task node in call to flyte node constructor, not sure if integration tests are actually running (#1422) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Sqlalchemy multiline query (#1421) * SQLAlchemyTask should handle multiline strings for query template Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * sqlalchemy supports multi-line query Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update base sql task Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * remove space Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix snowflake tests Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix lint Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix test Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * Sklearn type transformer should be automatically loaded with import flytekit (#1423) * add flytekit.extras.sklearn to main __init__ import Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix docs Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add temporary docs/requirements.txt for onnx plugins Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * Bump isort to 5.12.0 (#1427) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fixes guess type bug in UnionTransformer (#1426) Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> * Add `pod_template` and `pod_template_name` arguments for `PythonAutoContainerTask`, its downstream tasks, and `@task`. (#1425) * Add `pod_template` and `pod_template_name` arguments for `PythonAutoContainerTask`, its downstream tasks, and `@task` Signed-off-by: byhsu <byhsu@linkedin.com> * clean Signed-off-by: byhsu <byhsu@linkedin.com> * fix test Signed-off-by: byhsu <byhsu@linkedin.com> * Fix taskmetadata Signed-off-by: byhsu <byhsu@linkedin.com> * add kubernetes in setup.py Signed-off-by: byhsu <byhsu@linkedin.com> * address comments Signed-off-by: byhsu <byhsu@linkedin.com> * Regenerate requirements using python 3.7 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: byhsu <byhsu@linkedin.com> * keep container validation Signed-off-by: byhsu <byhsu@linkedin.com> * bump idl version Signed-off-by: byhsu <byhsu@linkedin.com> * Regenerate requirements using python 3.7 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Regenerate doc-requirements.txt Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * fix Signed-off-by: byhsu <byhsu@linkedin.com> --------- Signed-off-by: byhsu <byhsu@linkedin.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: byhsu <byhsu@linkedin.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Auto Backfill workflow (#1420) * Fix primitive decoder when evaluating Promise (#1432) Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * set maximum python version to 3.10 (#1433) * set maximum python version to 3.10 Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * remove unneeded python version check Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix lint Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * Revert "Remove project/domain from being overridden with execution values in serialized context (#1378)" (#1460) * Revert "Remove project/domain from being overridden with execution values in serialized context (#1378)" This reverts commit b3bfef5. * Import os Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Lint Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Support checkpointing in local mode from cached tasks (#1457) * support checkpointing in local mode from cached tasks * clear cache before tests --------- Co-authored-by: Stef Nelson-Lindall <stef@stripe.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> * Deprecate FlyteSchema (#1418) * Deprecate FlyteSchema Signed-off-by: Kevin Su <pingsutw@apache.org> * Remove version Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> * Use scarf images (#1434) * Use scarf images Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use scarf names in tests. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * add undocumented objects/functions to flytekit api ref (#1502) * add reference_launch_plan to flytekit api ref Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * import in init, add docstrings Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add more to references Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix lint Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix up docstrings Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Samhita Alla <aallasamhita@gmail.com> * Use non-root user in default flytekit image (#1417) Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix PyTorch transformer (#1510) Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * Fix mypy errors (#1313) * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix mypy errors Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix mypy errors Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * fix test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * Update type Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update dev-requirements.txt Signed-off-by: Kevin Su <pingsutw@apache.org> * Address comment Signed-off-by: Kevin Su <pingsutw@apache.org> * upgrade torch Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@gmail.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Compile the workflow only at compile time (#1311) * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * support dynamic task Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lazy compile Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update test Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> * Get the origin type when serializing dataclass (#1508) * Get the origin type when serializing dataclass Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update test Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> * Fix bad merge Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Delay initialization of SynchronousFlyteClient in FlyteRemote (#1514) * Delay initialization of SynchronousFlyteClient in FlyteRemote Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix spark plugin flyteremote test. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Lint Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Set flytekit and flyteidl bounds in plugins tests Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Fix mypy errors (#1313)" This reverts commit 3798450. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix requirements in dask and ray plugins Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix papermill tests requirements Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix doc-requirements Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * dask plugin requirements Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Revert "Add dask plugin #patch (#1366)" This reverts commit 41a9c7a. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Patrick Brogan <pbrogan12@gmail.com> Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> Signed-off-by: Bernhard Stadlbauer <bernhard@pachama.com> Signed-off-by: Peeter Piegaze <peeter@union.ai> Signed-off-by: Kevin Su <pingsutw@gmail.com> Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Ryan Nazareth <ryankarlos@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Samhita Alla <aallasamhita@gmail.com> Co-authored-by: H. Furkan Vural <33652917+hfurkanvural@users.noreply.github.com> Co-authored-by: Ketan Umare <16888709+kumare3@users.noreply.github.com> Co-authored-by: mcloney-ddm <119345186+mcloney-ddm@users.noreply.github.com> Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: pbrogan12 <pbrogan12@gmail.com> Co-authored-by: bstadlbauer <11799671+bstadlbauer@users.noreply.github.com> Co-authored-by: Peeter Piegaze <peeter@piegaze.com> Co-authored-by: Peeter Piegaze <peeter@union.ai> Co-authored-by: Haytham Abuelfutuh <haytham@afutuh.com> Co-authored-by: ByronHsu <byronhsu1230@gmail.com> Co-authored-by: byhsu <byhsu@linkedin.com> Co-authored-by: Stef Lindall <bethebunny@gmail.com> Co-authored-by: Stef Nelson-Lindall <stef@stripe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su pingsutw@apache.org
TL;DR
We should install
ray[default]instead ofray.ray[default]contains ray dashboard dependency, which will be used when we creating ray cluster. If we don't install it, ray operator will failed to submit the job to ray cluster because it can't find the dashboard IP address.https://docs.ray.io/en/latest/ray-core/ray-dashboard.html#getting-started
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
Might related to https://flyte-org.slack.com/archives/CP2HDHKE1/p1669843950108329
Follow-up issue
NA