Bring in buf protobufs #1363
Merged
Bring in buf protobufs #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
wild-endeavor,
kumare3 and
pingsutw
as code owners
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
wild-endeavor
previously approved these changes
Dec 7, 2022
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
- Coverage 69.08% 69.07% -0.02%
==========================================
Files 295 295
Lines 26928 26931 +3
Branches 2531 2532 +1
==========================================
- Hits 18604 18602 -2
- Misses 7829 7836 +7
+ Partials 495 493 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
force-pushed
the
bring-in-buf-protobufs
branch
from
6d7eea5
to
8c77c57
Compare
wild-endeavor
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Use new protobuf stubs generated in flyteidl
Type
Are all requirements met?
Complete description
This PR brings in flyteidl 1.3.0, which contains the first version of protobuf stubs generated via buf.
Once this PR is merged we will commence the work to delete all model files under https://github.com/flyteorg/flytekit/tree/master/flytekit/models without the loss of auto-completion and all niceties that those model files bring to the table, while at the same time removing a substantial portion of the code (~20%) of the code.
We also had to single out tensorflow loading code since its stubs are still using the old protobuf library. The tensorflow team documented the issue on their side. From the looks of it, there's someone actively working on the migration.
Tracking Issue
flyteorg/flyte#3139
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/