Always a default image and streamline image handling serialize vs package #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
pingsutw
previously approved these changes
Apr 26, 2023
eapolinario
previously approved these changes
May 25, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
changed the title
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
pingsutw
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
If not, if i do
pyflyte register --image custom=blah:latest ...and i have non-"custom" tasks, registration fails.Also this PR streamlines the behavior between
pyflyte serialize --image... andpyflyte package --image ...(see the issue below for more information)Type
flyteorg/flyte#3800