Add support image overriding #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario and
cosmicBboy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1652 +/- ##
=======================================
Coverage 71.02% 71.03%
=======================================
Files 336 336
Lines 30738 30749 +11
Branches 5566 5569 +3
=======================================
+ Hits 21832 21842 +10
- Misses 8353 8363 +10
+ Partials 553 544 -9
|
|
|
||
| @workflow | ||
| def wf() -> str: | ||
| bar().with_overrides(container_image="hello/world") |
There was a problem hiding this comment.
because people are used to
@task(container="{{ blah.fqn }}:{{ default.version }}")
...
can we make
bar().with_overrides(container_image="{{ blah.fqn }}:{{ default.version }}")
work?
There was a problem hiding this comment.
both imageSpec and that work for me.
2 tasks
wild-endeavor
approved these changes
May 24, 2023
ArthurBook
pushed a commit
to ArthurBook/flytekit
that referenced
this pull request
May 26, 2023
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Arthur <atte.book@gmail.com>
ArthurBook
added a commit
to ArthurBook/flytekit
that referenced
this pull request
Jun 12, 2023
This reverts commit 594026a.
eapolinario
pushed a commit
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario
added a commit
that referenced
this pull request
Jul 12, 2023
* Multi arch imageSpec (#1630) Multi arch imageSpec (#1630) Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add executor_path and applications_path to spark config (#1634) * Add executor_path and applications_path to spark config Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> * Add support for env vars to pyflyte run (#1617) * Add support for env vars to pyflyte run Signed-off-by: Kevin Su <pingsutw@apache.org> * bump idl Signed-off-by: Kevin Su <pingsutw@apache.org> * update doc Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fetch task executions in dynamic (#1636) * fetch task executions in dynamic Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> * Added metrics command to pyflyte (#1513) Signed-off-by: Daniel Rammer <daniel@union.ai> * Add http_proxy to client & Fix deviceflow (#1611) * Add http_proxy to client & Fix deviceflow RB=3890720 Signed-off-by: byhsu <byhsu@linkedin.com> * nit Signed-off-by: byhsu <byhsu@linkedin.com> * lint! Signed-off-by: byhsu <byhsu@linkedin.com> --------- Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Improve variable names (#1642) Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com> * Address resolution (#1567) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * pyflyte run supports pickle (#1646) Signed-off-by: Kevin Su <pingsutw@apache.org> * Wait for the pod plugin instead of flytekit (#1647) Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Beautify deviceflow prompt (#1625) * Beautify deviceflow prompt Signed-off-by: byhsu <byhsu@linkedin.com> * lint! Signed-off-by: byhsu <byhsu@linkedin.com> * lint Signed-off-by: byhsu <byhsu@linkedin.com> --------- Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com> * Improve flytekit register (#1643) * Fix pyflyte register Signed-off-by: byhsu <byhsu@linkedin.com> * revert Signed-off-by: byhsu <byhsu@linkedin.com> * lint Signed-off-by: byhsu <byhsu@linkedin.com> --------- Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com> * Pass verify flag to all authenticators (#1641) Signed-off-by: byhsu <byhsu@linkedin.com> * Allow annotated FlyteFile as task input argument (#1632) * fix: Allow annotated FlyteFile as task input argument Using an annotated FlyteFile type as an input to a task was previously impossible due to an exception being raised in `FlyteFilePathTransformer.to_python_value`. This commit applies the fix previously used in `FlyteFilePathTransformer.to_literal` to permit using annotated FlyteFiles as either inputs and outputs of a task. Issue: #3424 Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> * refactor: Unified handling of annotated types in type engine Issue: #3424 Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> * fix: Use py3.8-compatible types in type engine tests Issue: #3424 Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> --------- Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> * Use logger instead of print statement in sqlalchemy plugin (#1651) * use logging info instead of print Signed-off-by: wirthual <wirthra@gmail.com> * isorted files Signed-off-by: wirthual <wirthra@gmail.com> * import root logger from flytekit Signed-off-by: wirthual <wirthra@gmail.com> --------- Signed-off-by: wirthual <wirthra@gmail.com> * Map over notebook task (#1650) * map over notebook Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * add a flag Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> * Support single literals in tiny url (#1654) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * Add support overriding image (#1652) Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix ability to pass None to task with Optional kwarg, add test (#1657) Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com> * Regenerate plugins requirements Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Regenerate plugins requirements and linting Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> * Regenerate whylogs requirements Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Daniel Rammer <daniel@union.ai> Signed-off-by: byhsu <byhsu@linkedin.com> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Adrian Rumpold <a.rumpold@gmail.com> Signed-off-by: wirthual <wirthra@gmail.com> Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Dan Rammer <daniel@union.ai> Co-authored-by: ByronHsu <byronhsu1230@gmail.com> Co-authored-by: byhsu <byhsu@linkedin.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: eduardo apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Adrian Rumpold <a.rumpold@gmail.com> Co-authored-by: wirthual <wirthra@gmail.com> Co-authored-by: Fabio M. Graetz, Ph.D <fabiograetz@googlemail.com> Co-authored-by: Fabio Grätz <fabiogratz@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR allows people to override image by using
with_overridesType
Are all requirements met?
Complete description
^^^
Tracking Issue
https://flyte-org.slack.com/archives/CP2HDHKE1/p1683934828365009
Follow-up issue
NA