Csvtransform #1671
Merged
Csvtransform #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChungYujoyce
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
pingsutw
reviewed
Jun 7, 2023
Comment on lines
721
to
724
| def result_command(ctx: click.Context): | ||
| if ctx is not None: | ||
| filename = ctx.obj[RUN_LEVEL_PARAMS_KEY].get('filename') | ||
| if os.path.exists(filename): |
There was a problem hiding this comment.
Could you create a new PR? this PR should not contain these changes.
Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com>
Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com>
ChungYujoyce
force-pushed
the
csvtransform
branch
from
4dc0052
to
7261202
Compare
Codecov Report
@@ Coverage Diff @@
## master #1671 +/- ##
==========================================
+ Coverage 71.00% 71.03% +0.02%
==========================================
Files 336 336
Lines 30788 30839 +51
Branches 5587 5592 +5
==========================================
+ Hits 21862 21906 +44
+ Misses 8379 8376 -3
- Partials 547 557 +10
|
pingsutw
reviewed
Jun 14, 2023
tests/flytekit/unit/types/structured_dataset/test_structured_dataset_workflow.py
Outdated
Show resolved
Hide resolved
pingsutw
reviewed
Jun 14, 2023
Comment on lines
+39
to
+40
| class PandasToCSVEncodingHandler(StructuredDatasetEncoder): | ||
| def __init__(self): |
There was a problem hiding this comment.
You need to register the handler in this file
Signed-off-by: Joyce Huang (System) <Joyce_Huang@supermicro.com>
…ataset_workflow.py
pingsutw
previously approved these changes
Jun 29, 2023
pingsutw
approved these changes
Jul 6, 2023
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
Signed-off-by: ChungYujoyce <joyce.bhps@gmail.com> Signed-off-by: Joyce Huang (System) <Joyce_Huang@supermicro.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Joyce Huang (System) <Joyce_Huang@supermicro.com> Co-authored-by: Kevin Su <pingsutw@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Type transformation (Pandas <-> CSV) and its unit tests
Type
Are all requirements met?
Complete description
add an encoder and decoder for pandas <-> CSV transformation
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/