Use lazy_loader for pyspark #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhurana001
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
akhurana001
changed the title
akhurana001
changed the title
|
Please update the description completely |
kumare3
reviewed
Aug 27, 2020
| @@ -50,6 +50,7 @@ | |||
| "urllib3>=1.22,<2.0.0", | |||
| "wrapt>=1.0.0,<2.0.0", | |||
| "papermill>=1.2.0", | |||
| "ipykernel>=5.0.0", | |||
There was a problem hiding this comment.
See the description. Still not sure why it worked before but adding this does resolve the error I was seeing while testing: jupyter/notebook#1558
kumare3
reviewed
Aug 27, 2020
|
|
||
| from flytekit.common.types.helpers import pack_python_std_map_to_literal_map as _packer | ||
| from flytekit.contrib.notebook.supported_types import notebook_types_map as _notebook_types_map | ||
| from flytekit.plugins import pyspark as _pyspark |
There was a problem hiding this comment.
this will work because only when we access pyspark.x will it load the real module?
There was a problem hiding this comment.
Yeah, that's my understanding of lazy_loading here: https://github.com/lyft/flytekit/blob/master/flytekit/plugins/__init__.py#L5 . Have tested, it works.
wild-endeavor
approved these changes
Aug 28, 2020
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
* Remove dependence on pyspark for non-spark notebooks * Use lazy_loader for pyspark * lint * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Use lazy_loaded for pyspark so that non-spark notebooks can run without pyspark installed.
Also added a dependency on
ipykernel. Executions in my local venv were failing with aNo module named ipykernel_launcher.Type
Are all requirements met?
Complete description
Use lazy_loader for pyspark
Tracking Issue
flyteorg/flyte#488
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/