Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task type version in pytorch and mpi task plugin #1690

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

yubofredwang
Copy link
Contributor

@yubofredwang yubofredwang commented Jun 12, 2023

TL;DR

Previously the pytorch plugin is missing comments. We would suggest user to not set configurations for individual replica groups as they should essentially be the same for worker and master. The only fields user should set is number of worker and restart policies.

Fix a bug in pytorch and mpijob to use task type version 1.

Should be merged in after: flyteorg/flyteplugins#359

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Smoke tested on the following with corrected backend plugin

  1. Elastic Pytorch Job
  2. MPI Task
  3. Horovod Job

Yubo Wang and others added 3 commits June 12, 2023 14:04
Signed-off-by: Yubo Wang <yubwang@linkedin.com>
Signed-off-by: Yubo Wang <yubwang@linkedin.com>
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1690 (86c93d8) into master (3370a96) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1690   +/-   ##
=======================================
  Coverage   71.03%   71.03%           
=======================================
  Files         336      336           
  Lines       30798    30798           
  Branches     5589     5589           
=======================================
  Hits        21876    21876           
  Misses       8375     8375           
  Partials      547      547           

@pingsutw pingsutw merged commit 0f0416f into flyteorg:master Jun 15, 2023
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants