Support configuring pip index url with the image spec #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yini.gao@schibsted.com <yini.gao@schibsted.com>
yini7777
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: yini.gao@schibsted.com <yini.gao@schibsted.com>
|
cc @yini7777 envd plugin test is failing, mind taking a look |
Signed-off-by: yini.gao@schibsted.com <yini.gao@schibsted.com>
pingsutw
approved these changes
Jun 14, 2023
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Bug Fix
Complete description
Currently, we are unable to specify the pip index URL during package installation, although it is supported by envd.
The purpose of this PR is to enable configuring the custom pip index url.
Tracking Issue
flyteorg/flyte#3765