Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bigquery project and location to metadata #1702

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Add bigquery project and location to metadata #1702

merged 2 commits into from
Jun 26, 2023

Conversation

pingsutw
Copy link
Member

TL;DR

  • Add bigquery project and location to metadata
  • Return PERMANENT_FAILURE state if there is an error in BigQurey.job

Fixed https://flyte-org.slack.com/archives/CP2HDHKE1/p1683133259253529

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

https://flyte-org.slack.com/archives/CP2HDHKE1/p1683133259253529

Follow-up issue

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw marked this pull request as ready for review June 26, 2023 03:36
@pingsutw pingsutw merged commit 0b64f21 into master Jun 26, 2023
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants