Union | optional return types supported #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Union types iterate through all variants to find the right fit. The non right fits should raise an error to prevent the wrong cast. Today some type transfomers blindly tranform, this is ok for protobuf suppoerted typed, but for pickle, none this is a problem. Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
kumare3
requested review from
wild-endeavor,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
kumare3
changed the title
pingsutw
approved these changes
Jun 26, 2023
wild-endeavor
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Union types iterate through all variants to find the right fit. The incorrect fit should raise an error to prevent the wrong cast.
Prior to the PR certain type transfomers (like None Type), tranform without considering if the python object is acceptable or matches the type. In the case of protobuf supported types like int, string, float etc, doing an implicit conversion will raise a runtime error, but for transformers like pickle or none type, this is leads to incorrect behavior.
This is because,
Type
Are all requirements met?
This should fix the following
fixes flyteorg/flyte#3319