Memory reduction change #1716
Merged
Memory reduction change #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
wild-endeavor
changed the title
pingsutw
approved these changes
Jul 5, 2023
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Don't have the memory profile that ketan did but this is supposed to save ~50 mb in memory in certain cases.
Type
Are all requirements met?
Complete description
Profiling was done with memray. Don't have the results though.
Tracking Issue
NA