Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to execution #1723

Merged
merged 12 commits into from
Aug 10, 2023
Merged

Add tags to execution #1723

merged 12 commits into from
Aug 10, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jul 6, 2023

TL;DR

Blocked by flyteorg/flyteadmin#571

pyflyte run --remote --tag "hello" --tag "flyte" workflow.py wf

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added a new arg (tags) to execution

Tracking Issue

flyteorg/flyte#3320

Follow-up issue

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw and others added 9 commits July 31, 2023 10:51
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw merged commit edfa767 into master Aug 10, 2023
130 checks passed
fg91 pushed a commit that referenced this pull request Aug 15, 2023
* wip

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Add tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Use JsonParamType instead

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update idl

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update idl

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update idl

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update idl

Signed-off-by: Kevin Su <pingsutw@apache.org>

* bump grpcio-status version

Signed-off-by: Kevin Su <pingsutw@apache.org>

* bump grpcioversion

Signed-off-by: Kevin Su <pingsutw@apache.org>

---------

Signed-off-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Future-Outlier pushed a commit to Future-Outlier/flytekit that referenced this pull request Oct 3, 2023
* wip

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Add tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* Use JsonParamType instead

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update idl

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update idl

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update idl

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update idl

Signed-off-by: Kevin Su <pingsutw@apache.org>

* bump grpcio-status version

Signed-off-by: Kevin Su <pingsutw@apache.org>

* bump grpcioversion

Signed-off-by: Kevin Su <pingsutw@apache.org>

---------

Signed-off-by: Kevin Su <pingsutw@apache.org>
Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants