use getattr to access task_def.disable_deck in entrypoint #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flyteorg/flyte#3841 Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
cosmicBboy
requested review from
wild-endeavor,
kumare3,
eapolinario and
pingsutw
as code owners
eapolinario
previously approved these changes
Jul 6, 2023
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
eapolinario
approved these changes
Jul 6, 2023
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
* use getattr to access task_def.disable_deck in entrypoint Fixes flyteorg/flyte#3841 Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * invert conditional Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flyteorg/flyte#3841
TL;DR
#1693 introduced a bug in task templates like
SQlite3Task. This PR fixes an issue in the execution entrypoint that assumes the all task objects have thedisable_deckattribute.Type
Are all requirements met?
Complete description
Use the
getattrfunction to getdisable_deck, and returnFalseif not present.Tracking Issue
https://github.com/flyteorg/flyte/issues/